From: Michal Privoznik <mprivozn@redhat.com>
Date: Fri, 10 Jul 2020 08:42:01 +0000 (+0200)
Subject: virSecurityManagerMetadataLock: Clarify directory locking comment
X-Git-Tag: v6.6.0-rc1~168
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a145de970af31e605d837c3502855fe93aaec9a;p=thirdparty%2Flibvirt.git

virSecurityManagerMetadataLock: Clarify directory locking comment

In the light of recent commit of 9d83281382 fix the comment that
says directories can't be locked. Well, in general they can, but
not in our case.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/security/security_manager.c b/src/security/security_manager.c
index ad1938caeb..d26d3a0527 100644
--- a/src/security/security_manager.c
+++ b/src/security/security_manager.c
@@ -1353,7 +1353,8 @@ virSecurityManagerMetadataLock(virSecurityManagerPtr mgr G_GNUC_UNUSED,
             continue;
 
         if (S_ISDIR(sb.st_mode)) {
-            /* Directories can't be locked */
+            /* We need to open the path for writing because we need exclusive
+             * (write) lock. But directories can't be opened for writing. */
             continue;
         }