From: Ralph Boehme <slow@samba.org>
Date: Fri, 7 Mar 2025 13:47:49 +0000 (+0100)
Subject: s3:locking: assert POSIX_LOCK in brl_[un]lock_posix()
X-Git-Tag: tevent-0.17.0~576
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a1e3638154f955b9383517af2ca4192bf81046f;p=thirdparty%2Fsamba.git

s3:locking: assert POSIX_LOCK in brl_[un]lock_posix()

This makes it clearer and prevents possible problems in future.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/locking/brlock.c b/source3/locking/brlock.c
index b0295174954..9b42068a66c 100644
--- a/source3/locking/brlock.c
+++ b/source3/locking/brlock.c
@@ -757,6 +757,8 @@ static NTSTATUS brl_lock_posix(struct byte_range_lock *br_lck,
 	bool break_oplocks = false;
 	NTSTATUS status;
 
+	SMB_ASSERT(plock->lock_flav == POSIX_LOCK);
+
 	/* No zero-zero locks for POSIX. */
 	if (plock->start == 0 && plock->size == 0) {
 		return NT_STATUS_INVALID_PARAMETER;
@@ -1024,6 +1026,8 @@ static bool brl_unlock_posix(struct byte_range_lock *br_lck,
 	struct lock_struct *locks = br_lck->lock_data;
 	bool overlap_found = False;
 
+	SMB_ASSERT(plock->lock_flav == POSIX_LOCK);
+
 	/* No zero-zero locks for POSIX. */
 	if (plock->start == 0 && plock->size == 0) {
 		return False;