From: Aki Tuomi <cmouse@cmouse.fi>
Date: Mon, 23 Nov 2015 20:47:43 +0000 (+0200)
Subject: Correctly construct pointer
X-Git-Tag: dnsdist-1.0.0-alpha1~207^2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a547e086a05b7a576d794255925546abae8f43a;p=thirdparty%2Fpdns.git

Correctly construct pointer
---

diff --git a/modules/godbcbackend/sodbc.cc b/modules/godbcbackend/sodbc.cc
index 52518a399a..e68611a320 100644
--- a/modules/godbcbackend/sodbc.cc
+++ b/modules/godbcbackend/sodbc.cc
@@ -111,7 +111,7 @@ public:
 
   SSqlStatement* bind(const string& name, uint32_t value) {
     ODBCParam p;
-    p.ParameterValuePtr = new UDWORD[1] {value};
+    p.ParameterValuePtr = new UDWORD {value};
     p.LenPtr = new SQLLEN {sizeof(UDWORD)};
     p.ParameterType = SQL_INTEGER;
     p.ValueType = SQL_INTEGER;
@@ -120,7 +120,7 @@ public:
 
   SSqlStatement* bind(const string& name, unsigned long value) {
     ODBCParam p;
-    p.ParameterValuePtr = new ULONG[1] {value};
+    p.ParameterValuePtr = new ULONG {value};
     p.LenPtr = new SQLLEN {sizeof(ULONG)};
     p.ParameterType = SQL_INTEGER;
     p.ValueType = SQL_INTEGER;
@@ -129,7 +129,7 @@ public:
 
   SSqlStatement* bind(const string& name, unsigned long long value) {
     ODBCParam p;
-    p.ParameterValuePtr = new unsigned long long[1] {value};
+    p.ParameterValuePtr = new unsigned long long {value};
     p.LenPtr = new SQLLEN {sizeof(unsigned long long)};
     p.ParameterType = SQL_BIGINT;
     p.ValueType = SQL_C_UBIGINT;
@@ -218,8 +218,8 @@ public:
 
     for(auto &i: d_req_bind) {
       if (i.ParameterType == SQL_VARCHAR) delete [] (char*)i.ParameterValuePtr;
-      else if (i.ParameterType == SQL_INTEGER) delete [] (ULONG*)i.ParameterValuePtr;
-      else if (i.ParameterType == SQL_C_UBIGINT) delete [] (unsigned long long*)i.ParameterValuePtr;
+      else if (i.ParameterType == SQL_INTEGER) delete (ULONG*)i.ParameterValuePtr;
+      else if (i.ParameterType == SQL_C_UBIGINT) delete (unsigned long long*)i.ParameterValuePtr;
       delete i.LenPtr;
     }
     d_req_bind.clear();