From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sat, 13 Jan 2018 13:43:58 +0000 (+0000)
Subject: Don't perform LDAP search with empty input
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a5a0f584e067faa22e1a49f18fab5fa8ded2060;p=pbs.git

Don't perform LDAP search with empty input

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/buildservice/ldap.py b/src/buildservice/ldap.py
index ca329305..efa08ee9 100644
--- a/src/buildservice/ldap.py
+++ b/src/buildservice/ldap.py
@@ -66,6 +66,10 @@ class LDAP(base.Object):
 		return self.get_dn_by_uid(name) or self.get_dn_by_mail(name)
 
 	def get_user_by_uid(self, uid, **kwargs):
+		# Do not execute search with empty uid
+		if not uid:
+			return None, None
+
 		result = self.search("(&(objectClass=posixAccount)(uid=%s))" % uid, limit=1, **kwargs)
 		for dn, attrs in result:
 			return dn, attrs
@@ -73,6 +77,10 @@ class LDAP(base.Object):
 		return None, None
 
 	def get_user_by_mail(self, mail, **kwargs):
+		# Do not execute search with empty mail
+		if not mail:
+			return None, None
+
 		result = self.search("(&(objectClass=posixAccount)(mail=%s))" % mail, limit=1, **kwargs)
 		for dn, attrs in result:
 			return dn, attrs