From: Peter Krempa Date: Wed, 16 Feb 2022 12:38:56 +0000 (+0100) Subject: virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_REMOTE_(CLOSE|EVENT)_CALLBACK X-Git-Tag: v8.1.0-rc1~35 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a6335cd224909942f93024cf54961c8a0236395;p=thirdparty%2Flibvirt.git virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_REMOTE_(CLOSE|EVENT)_CALLBACK They are features of the RPC; drivers must say that it's not supported. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- diff --git a/src/driver.c b/src/driver.c index 6bebfeba58..9852a1cb17 100644 --- a/src/driver.c +++ b/src/driver.c @@ -345,6 +345,11 @@ virDriverFeatureIsGlobal(virDrvFeature feat, /* keepalive is handled at RPC level, driver implementations must always * return 0, to signal that direct/embedded use doesn't use keepalive */ case VIR_DRV_FEATURE_PROGRAM_KEEPALIVE: + /* Support for close callbacks and remote event filtering are both features + * of the RPC protocol and thus normal drivers must not signal support + * for them. */ + case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: + case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: *supported = 0; return true; @@ -360,8 +365,6 @@ virDriverFeatureIsGlobal(virDrvFeature feat, case VIR_DRV_FEATURE_MIGRATION_PARAMS: case VIR_DRV_FEATURE_MIGRATION_DIRECT: case VIR_DRV_FEATURE_MIGRATION_V1: - case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: - case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: default: return false; }