From: Nicki Křížek <nicki@isc.org>
Date: Tue, 17 Jun 2025 15:21:33 +0000 (+0200)
Subject: Don't log empty test result messages
X-Git-Tag: v9.21.10~15^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a6b0cf68c6553f7eeef06fb507c1b28b9c61f38;p=thirdparty%2Fbind9.git

Don't log empty test result messages

The messages obtained from test results may contain stuff like detailed
failure/error information, tracebacks etc. In many cases, the message
will be empty, in which case it doesn't need to be logged.

For an example, run test with many test cases, e.g.
verify/test_verify.py, and inspect the tail of the pytest.log.txt before
and after this commit.
---

diff --git a/bin/tests/system/conftest.py b/bin/tests/system/conftest.py
index 89bbad7d19d..ee87d618b49 100644
--- a/bin/tests/system/conftest.py
+++ b/bin/tests/system/conftest.py
@@ -365,7 +365,8 @@ def system_test_dir(request, system_test_name, expected_artifacts):
             isctest.log.debug("%s %s", result.outcome.upper(), node)
             messages.extend(result.messages.values())
         for message in messages:
-            isctest.log.debug("\n" + message)
+            if message:
+                isctest.log.debug("\n" + message)
         failed = any(res.outcome == "failed" for res in test_results.values())
         skipped = any(res.outcome == "skipped" for res in test_results.values())
         if failed: