From: Brian Wellington <bwelling@xbill.org>
Date: Tue, 7 Jul 2020 17:44:04 +0000 (-0700)
Subject: Fix Message.want_dnssec().
X-Git-Tag: v2.0.0~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a6b2c26056ce6f7962e52869b1809e2c29d7dbc;p=thirdparty%2Fdnspython.git

Fix Message.want_dnssec().

It was incorrectly calling Message._make_opt() in the case where the
message was not currently using EDNS.
---

diff --git a/dns/message.py b/dns/message.py
index 43b837a8..1bb02ae2 100644
--- a/dns/message.py
+++ b/dns/message.py
@@ -615,7 +615,7 @@ class Message:
         if self.opt:
             self.opt.ttl = v
         else:
-            self.opt = self._make_opt(0, v)
+            self.opt = self._make_opt(v)
 
     @property
     def payload(self):
diff --git a/tests/test_message.py b/tests/test_message.py
index 1a5dceaf..4eb48d3a 100644
--- a/tests/test_message.py
+++ b/tests/test_message.py
@@ -336,6 +336,7 @@ class MessageTestCase(unittest.TestCase):
         self.assertEqual(m.edns, -1)
         m.want_dnssec()
         self.assertEqual(m.edns, 0)
+        self.assertTrue(m.ednsflags & dns.flags.DO)
 
     def test_from_file(self):
         m = dns.message.from_file(here('query'))