From: Ondřej Surý <ondrej@sury.org>
Date: Wed, 31 Mar 2021 06:59:03 +0000 (+0200)
Subject: Disable netmgr tests only when running under CI
X-Git-Tag: v9.17.12~10^2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0aad97917586e0232d2b99b6220e00d68da7ad40;p=thirdparty%2Fbind9.git

Disable netmgr tests only when running under CI

The full netmgr test suite is unstable when run in CI due to various
timing issues.  Previously, we enabled the full test suite only when
CI_ENABLE_ALL_TESTS environment variable was set, but that went against
original intent of running the full suite when an individual developer
would run it locally.

This change disables the full test suite only when running in the CI and
the CI_ENABLE_ALL_TESTS is not set.
---

diff --git a/lib/isc/tests/netmgr_test.c b/lib/isc/tests/netmgr_test.c
index 2657a948646..c52bf11c322 100644
--- a/lib/isc/tests/netmgr_test.c
+++ b/lib/isc/tests/netmgr_test.c
@@ -191,7 +191,7 @@ _setup(void **state __attribute__((unused))) {
 
 	signal(SIGPIPE, SIG_IGN);
 
-	if (getenv("CI_ENABLE_ALL_TESTS") != NULL) {
+	if (getenv("CI") == NULL || getenv("CI_ENABLE_ALL_TESTS") != NULL) {
 		esends = NSENDS * workers;
 	} else {
 		esends = workers;