From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 9 Nov 2021 18:28:24 +0000 (+0000)
Subject: request: Fix segmentation fault when archive could not be opened
X-Git-Tag: 0.9.28~881
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ab410c3374186e877dd18558d24973bc41aeddf;p=pakfire.git

request: Fix segmentation fault when archive could not be opened

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/request.c b/src/libpakfire/request.c
index c27a8af77..e3edcdb02 100644
--- a/src/libpakfire/request.c
+++ b/src/libpakfire/request.c
@@ -418,7 +418,7 @@ ERROR:
 
 static int pakfire_request_add_file(struct pakfire_request* request, int action,
 		const char* path, int extra_flags) {
-	struct pakfire_archive* archive;
+	struct pakfire_archive* archive = NULL;
 
 	// Open the archive
 	int r = pakfire_archive_open(&archive, request->pakfire, path);
@@ -434,7 +434,8 @@ static int pakfire_request_add_file(struct pakfire_request* request, int action,
 	r = 0;
 
 ERROR:
-	pakfire_archive_unref(archive);
+	if (archive)
+		pakfire_archive_unref(archive);
 
 	return r;
 }