From: Andy Shevchenko Date: Thu, 19 Feb 2026 13:46:47 +0000 (+0100) Subject: gpio: ts4800: Remove duplicate code to handle 'ngpios' property X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0acbe817c37344f10cb413663be494ad66bf40bc;p=thirdparty%2Fkernel%2Flinux.git gpio: ts4800: Remove duplicate code to handle 'ngpios' property The gpio_generic_chip_init() handles the 'ngpios' property and assigns the respective field in struct gpio_chip either with the value of it, or, if not found, with the default based on the register size. There is no need to repeat this in the driver. Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij Link: https://patch.msgid.link/20260219134647.2258593-1-andriy.shevchenko@linux.intel.com Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c index 992ee231db9ff..0207c2b813f41 100644 --- a/drivers/gpio/gpio-ts4800.c +++ b/drivers/gpio/gpio-ts4800.c @@ -11,7 +11,6 @@ #include #include -#define DEFAULT_PIN_NUMBER 16 #define INPUT_REG_OFFSET 0x00 #define OUTPUT_REG_OFFSET 0x02 #define DIRECTION_REG_OFFSET 0x04 @@ -23,7 +22,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev) struct gpio_generic_chip *chip; void __iomem *base_addr; int retval; - u32 ngpios; chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); if (!chip) @@ -33,12 +31,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev) if (IS_ERR(base_addr)) return PTR_ERR(base_addr); - retval = device_property_read_u32(dev, "ngpios", &ngpios); - if (retval == -EINVAL) - ngpios = DEFAULT_PIN_NUMBER; - else if (retval) - return retval; - config = (struct gpio_generic_chip_config) { .dev = dev, .sz = 2, @@ -52,8 +44,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev) return dev_err_probe(dev, retval, "failed to initialize the generic GPIO chip\n"); - chip->gc.ngpio = ngpios; - return devm_gpiochip_add_data(dev, &chip->gc, NULL); }