From: Michal Privoznik <mprivozn@redhat.com>
Date: Fri, 14 Aug 2015 13:36:05 +0000 (+0200)
Subject: qemuDomainRename: Explicitly check if domain is renaming to itself
X-Git-Tag: v1.2.19-rc1~57
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ace4d985ad0a0475698f9335d688d567fea2576;p=thirdparty%2Flibvirt.git

qemuDomainRename: Explicitly check if domain is renaming to itself

It may happen that user (mistakenly) wants to rename a domain to
itself. Which is no renaming at all. We should reject that with
some meaningful error message.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 4c0532432a..083e4ff823 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -19937,6 +19937,12 @@ static int qemuDomainRename(virDomainPtr dom,
         goto endjob;
     }
 
+    if (STREQ(vm->def->name, new_name)) {
+        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
+                       _("Can't rename domain to itself"));
+        goto cleanup;
+    }
+
     if (VIR_STRDUP(new_dom_name, new_name) < 0)
         goto endjob;