From: Syed Mohammed Nayyar Date: Mon, 29 Jun 2026 06:02:14 +0000 (+0530) Subject: string-util: add strnspn() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0af6caff42b53dbf740cc08ca77aab31ec405284;p=thirdparty%2Fsystemd.git string-util: add strnspn() Like strspn(), but reads at most 'n' bytes from the input. strspn() is bounded only by a non-matching byte or a NUL, so it over-reads a buffer that is all matching bytes and not NUL terminated within 'n'. --- diff --git a/src/basic/string-util.c b/src/basic/string-util.c index 1dc90d538ad..f9383e958fe 100644 --- a/src/basic/string-util.c +++ b/src/basic/string-util.c @@ -1389,6 +1389,23 @@ size_t strspn_from_end(const char *str, const char *accept) { return n; } +size_t strnspn(const char *str, const char *accept, size_t n) { + size_t i; + + /* Like strspn(), but reads at most 'n' bytes from 'str'. Returns the length of the initial + * run of 'str' (capped at 'n') that consists solely of bytes found in 'accept'. Stops at a + * NUL byte too. Unlike strspn() this is safe on a buffer that is not NUL terminated within + * 'n' bytes. */ + + assert(str || n == 0); + assert(accept); + + for (i = 0; i < n && str[i] != '\0' && strchr(accept, str[i]); i++) + ; + + return i; +} + char* strdupspn(const char *a, const char *accept) { if (isempty(a) || isempty(accept)) return strdup(""); diff --git a/src/basic/string-util.h b/src/basic/string-util.h index 68ab38c3211..355f7478c3d 100644 --- a/src/basic/string-util.h +++ b/src/basic/string-util.h @@ -286,6 +286,7 @@ typedef enum MakeCStringMode { int make_cstring(const void *s, size_t n, MakeCStringMode mode, char **ret); size_t strspn_from_end(const char *str, const char *accept) _pure_; +size_t strnspn(const char *str, const char *accept, size_t n) _pure_ _nonnull_if_nonzero_(1, 3); char* strdupspn(const char *a, const char *accept); char* strdupcspn(const char *a, const char *reject); diff --git a/src/test/test-string-util.c b/src/test/test-string-util.c index 970421c7abb..2ebcb440452 100644 --- a/src/test/test-string-util.c +++ b/src/test/test-string-util.c @@ -1286,6 +1286,26 @@ TEST(strspn_from_end) { assert_se(strspn_from_end("aaa12aa34", DIGITS) == 2); } +TEST(strnspn) { + assert_se(strnspn(NULL, WHITESPACE, 0) == 0); + assert_se(strnspn("", WHITESPACE, 0) == 0); + assert_se(strnspn("hoge", WHITESPACE, 0) == 0); + assert_se(strnspn("hoge", WHITESPACE, 4) == 0); + assert_se(strnspn(" hoge", WHITESPACE, 7) == 3); + assert_se(strnspn(" hoge", WHITESPACE, 2) == 2); + assert_se(strnspn(" ", WHITESPACE, 4) == 4); + + /* 'str' is all whitespace and not NUL terminated within 'n': at most 'n' bytes may be read, + * otherwise this reads off the end of the buffer (caught by the sanitizers). */ + for (size_t n = 1; n <= 64; n++) { + _cleanup_free_ char *str = NULL; + + assert_se(str = new(char, n)); + memset(str, ' ', n); + assert_se(strnspn(str, WHITESPACE, n) == n); + } +} + TEST(streq_skip_trailing_chars) { /* NULL is WHITESPACE by default */ assert_se(streq_skip_trailing_chars("foo bar", "foo bar", NULL));