From: Julian Seward <jseward@acm.org>
Date: Mon, 31 Aug 2015 14:37:25 +0000 (+0000)
Subject: Change the default setting for --dsymutil from =no to =yes, since
X-Git-Tag: svn/VALGRIND_3_11_0~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b063cb3c3d767091f7bc4f7396392279745c0fc;p=thirdparty%2Fvalgrind.git

Change the default setting for --dsymutil from =no to =yes, since
in practice it needs to be permanently enabled on OS X.  No change
on other platforms.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15603
---

diff --git a/coregrind/m_main.c b/coregrind/m_main.c
index cd9cad10cc..afe69ad733 100644
--- a/coregrind/m_main.c
+++ b/coregrind/m_main.c
@@ -134,7 +134,7 @@ static void usage_NORETURN ( Bool debug_help )
 "    --suppressions=<filename> suppress errors described in <filename>\n"
 "    --gen-suppressions=no|yes|all    print suppressions for errors? [no]\n"
 "    --input-fd=<number>       file descriptor for input [0=stdin]\n"
-"    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [no]\n"
+"    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [yes]\n"
 "    --max-stackframe=<number> assume stack switch for SP changes larger\n"
 "                              than <number> bytes [2000000]\n"
 "    --main-stacksize=<number> set size of main thread's stack (in bytes)\n"
diff --git a/coregrind/m_options.c b/coregrind/m_options.c
index 4cf2d1036a..7e920e0625 100644
--- a/coregrind/m_options.c
+++ b/coregrind/m_options.c
@@ -130,7 +130,7 @@ Word   VG_(clo_main_stacksize) = 0; /* use client's rlimit.stack */
 Word   VG_(clo_valgrind_stacksize) = VG_DEFAULT_STACK_ACTIVE_SZB;
 Bool   VG_(clo_wait_for_gdb)   = False;
 UInt   VG_(clo_kernel_variant) = 0;
-Bool   VG_(clo_dsymutil)       = False;
+Bool   VG_(clo_dsymutil)       = True;
 Bool   VG_(clo_sigill_diag)    = True;
 UInt   VG_(clo_unw_stack_scan_thresh) = 0; /* disabled by default */
 UInt   VG_(clo_unw_stack_scan_frames) = 5;
diff --git a/docs/xml/manual-core.xml b/docs/xml/manual-core.xml
index b8d1f577c0..e384550262 100644
--- a/docs/xml/manual-core.xml
+++ b/docs/xml/manual-core.xml
@@ -1470,7 +1470,7 @@ that can report errors, e.g. Memcheck, but not Cachegrind.</para>
 
   <varlistentry id="opt.dsymutil" xreflabel="--dsymutil">
     <term>
-      <option><![CDATA[--dsymutil=no|yes [no] ]]></option>
+      <option><![CDATA[--dsymutil=no|yes [yes] ]]></option>
     </term>
     <listitem>
       <para>This option is only relevant when running Valgrind on
diff --git a/none/tests/cmdline1.stdout.exp b/none/tests/cmdline1.stdout.exp
index 3617545e3f..e698ad1d22 100644
--- a/none/tests/cmdline1.stdout.exp
+++ b/none/tests/cmdline1.stdout.exp
@@ -48,7 +48,7 @@ usage: valgrind [options] prog-and-args
     --suppressions=<filename> suppress errors described in <filename>
     --gen-suppressions=no|yes|all    print suppressions for errors? [no]
     --input-fd=<number>       file descriptor for input [0=stdin]
-    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [no]
+    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [yes]
     --max-stackframe=<number> assume stack switch for SP changes larger
                               than <number> bytes [2000000]
     --main-stacksize=<number> set size of main thread's stack (in bytes)
diff --git a/none/tests/cmdline2.stdout.exp b/none/tests/cmdline2.stdout.exp
index 88110ec370..ca948a8577 100644
--- a/none/tests/cmdline2.stdout.exp
+++ b/none/tests/cmdline2.stdout.exp
@@ -48,7 +48,7 @@ usage: valgrind [options] prog-and-args
     --suppressions=<filename> suppress errors described in <filename>
     --gen-suppressions=no|yes|all    print suppressions for errors? [no]
     --input-fd=<number>       file descriptor for input [0=stdin]
-    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [no]
+    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [yes]
     --max-stackframe=<number> assume stack switch for SP changes larger
                               than <number> bytes [2000000]
     --main-stacksize=<number> set size of main thread's stack (in bytes)