From: Victor Julien <victor@inliniac.net>
Date: Tue, 23 Oct 2018 14:17:26 +0000 (+0200)
Subject: htp: fix potential (but unlikely) memleak in uri normalization
X-Git-Tag: suricata-4.0.6~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b0860586808da216cd8cc38aadd7a8fc2233ca2;p=thirdparty%2Fsuricata.git

htp: fix potential (but unlikely) memleak in uri normalization
---

diff --git a/src/app-layer-htp-libhtp.c b/src/app-layer-htp-libhtp.c
index 3f040213fa..a4ef784b0e 100644
--- a/src/app-layer-htp-libhtp.c
+++ b/src/app-layer-htp-libhtp.c
@@ -127,7 +127,7 @@ bstr *SCHTPGenerateNormalizedUri(htp_tx_t *tx, htp_uri_t *uri, int uri_include_a
                 bstr_add_noex(r, uri->username);
             }
 
-            bstr_add_c(r, ":");
+            bstr_add_c_noex(r, ":");
 
             if (uri->password != NULL) {
                 bstr_add_noex(r, uri->password);
@@ -141,7 +141,7 @@ bstr *SCHTPGenerateNormalizedUri(htp_tx_t *tx, htp_uri_t *uri, int uri_include_a
         }
 
         if (uri->port != NULL) {
-            bstr_add_c(r, ":");
+            bstr_add_c_noex(r, ":");
             bstr_add_noex(r, uri->port);
         }
     }