From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 22 Aug 2022 12:58:13 +0000 (+0200)
Subject: lgtm: dirname() is now icky
X-Git-Tag: v252-rc1~363^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b1c6448bed4e925a4ec5aa160c0aa90b5768185;p=thirdparty%2Fsystemd.git

lgtm: dirname() is now icky
---

diff --git a/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql b/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
index 39e8dddd13a..63fd14e75f6 100644
--- a/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
+++ b/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
@@ -46,6 +46,9 @@ predicate potentiallyDangerousFunction(Function f, string message) {
   ) or (
     f.getQualifiedName() = "accept" and
     message = "Call to accept() is not O_CLOEXEC-safe. Use accept4() instead."
+  ) or (
+    f.getQualifiedName() = "dirname" and
+    message = "Call dirname() is icky. Use path_extract_directory() instead."
   )
 }