From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Fri, 20 May 2022 14:29:04 +0000 (-0600)
Subject: src/config: fix coverity warning about add missing unlock()
X-Git-Tag: v2.0.3~58
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b1dd319c1bb8eab1feb8d9e19b82934344822cf;p=thirdparty%2Flibcgroup.git

src/config: fix coverity warning about add missing unlock()

Add missing unlock() of cg_mount_table_lock, reported by Coverity tool:

CID 1412126 (#1 of 1): Missing unlock (LOCK). missing_unlock:
Returning without unlocking cg_mount_table_lock.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
(cherry picked from commit 750388bda000a1ac00550ae400a4b5ace3dc1c37)
---

diff --git a/src/config.c b/src/config.c
index 1306033b..32a44b88 100644
--- a/src/config.c
+++ b/src/config.c
@@ -976,8 +976,10 @@ static int config_order_namespace_table(void)
 				}
 			}
 		}
-		if (!flag)
-			return ECGNAMESPACECONTROLLER;
+		if (!flag) {
+			error = ECGNAMESPACECONTROLLER;
+			break;
+		}
 	}
 error_out:
 	pthread_rwlock_unlock(&cg_mount_table_lock);