From: Katy Feng <fkaty@vmware.com>
Date: Fri, 23 Dec 2022 00:25:50 +0000 (-0800)
Subject: Limit retry if the VMX RESETs a vsock connection
X-Git-Tag: stable-12.2.0~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b2992f6718150d7c04ce4268e071033d4222e45;p=thirdparty%2Fopen-vm-tools.git

Limit retry if the VMX RESETs a vsock connection

If guest_rpc.rpci.usevsocket = "FALSE" is set, a vsock
connect() will always fail with RESET. This confused code that
thought it could only happen for secure sockets when they
were quickly re-used.

Limit retry, and only for secure connections.
---

diff --git a/open-vm-tools/vgauth/common/vmxrpc.c b/open-vm-tools/vgauth/common/vmxrpc.c
index b4cd5a662..8ed32f7d7 100644
--- a/open-vm-tools/vgauth/common/vmxrpc.c
+++ b/open-vm-tools/vgauth/common/vmxrpc.c
@@ -47,6 +47,14 @@
 #include <assert.h>
 #include <errno.h>
 
+
+/*
+ * Max number of times to try to connect to the VMX if the connection
+ * keeps getting reset.  This can also occur if vsock is disabled for RPCs.
+ * See PR 3048949, PR 728832.
+ */
+#define MAX_CONN_RETRIES 5
+
 /*
  * VMX listening address
  */
@@ -370,6 +378,7 @@ CreateVMCISocket(gboolean useSecure)
    int errCode;
    unsigned int localPort = PRIVILEGED_PORT_MAX;
    SOCKET fd;
+   int retryCount = 0;
 
 again:
    fd = socket(gAddressFamily, SOCK_STREAM, 0);
@@ -428,14 +437,20 @@ bound:
    ret = connect(fd, (struct sockaddr *)&addr, sizeof addr);
    if (ret < 0) {
       errCode = GetSocketErrCode();
-      if (errCode == SYSERR_ECONNRESET) {
+      if (errCode == SYSERR_ECONNRESET && useSecure) {
          /*
           * VMX might be slow releasing a port pair
           * when another client closed the client side end.
-          * Simply try next port.
+          * Try next port.
+          * This can also occur if there's no listen socket in the VMX.
           */
          g_debug("%s: connect() failed with RESET, trying another port\n",
                  __FUNCTION__);
+         if (++retryCount >= MAX_CONN_RETRIES) {
+            g_warning("%s: connect() RESET %d times, giving up\n",
+                      __FUNCTION__, MAX_CONN_RETRIES);
+            goto err;
+         }
          localPort--;
          Socket_Close(fd);
          goto again;
@@ -626,7 +641,7 @@ main(int argc, char **argv)
       fprintf(stderr, "%s: needs an RPC arg\n", argv[0]);
       exit(-1);
    }
-   ret = VMXRPC_SendRpc(argv[1], TRUE, &reply);
+   ret = VMXRPC_SendRpc(argv[1], FALSE, &reply);
    if (ret < 0) {
       fprintf(stderr, "%s: failed to send RPC\n", argv[0]);
       exit(-1);