From: Garming Sam Date: Thu, 22 Mar 2018 03:54:59 +0000 (+1300) Subject: netlogon: Add a comment regarding one of the DC location calls X-Git-Tag: ldb-1.4.0~433 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b6186bfce3f0f251ea57c7a01d0bf608fdb1805;p=thirdparty%2Fsamba.git netlogon: Add a comment regarding one of the DC location calls It appears to be basically deprecated, as it was superceded by other calls. Presumably it is also unused. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365 Signed-off-by: Garming Sam Reviewed-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett --- diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c index 60761b8b3ee..cab27d20b16 100644 --- a/source4/rpc_server/netlogon/dcerpc_netlogon.c +++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c @@ -2953,10 +2953,14 @@ static WERROR dcesrv_netr_DsRGetDCNameEx(struct dcesrv_call_state *dce_call, TAL } /* - netr_DsRGetDCName -*/ + * netr_DsRGetDCName + * + * This function is a predecessor to DsrGetDcNameEx2 according to [MS-NRPC]. + * Although it has a site-guid parameter, the documentation 3.5.4.3.3 DsrGetDcName + * insists that it be ignored. + */ static WERROR dcesrv_netr_DsRGetDCName(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx, - struct netr_DsRGetDCName *r) + struct netr_DsRGetDCName *r) { struct netr_DsRGetDCNameEx2 r2; WERROR werr;