From: Justin Squirek <squirek@adacore.com>
Date: Thu, 21 Dec 2023 18:31:27 +0000 (+0000)
Subject: ada: Spurious reference warning on qualified expression
X-Git-Tag: basepoints/gcc-16~9363
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b7c0811ced8c98b4bebd1bc89f2272216000900;p=thirdparty%2Fgcc.git

ada: Spurious reference warning on qualified expression

This patch fixes an error in the compiler whereby an assignment to an out
formal (whose type requires a predicate check) can lead to spurious
"value may be referenced before it has a value" warnings when the RHS is a
qualified expression.

gcc/ada/

	* sem_warn.adb (Within_Postcondition): Add case to ignore
	references within generated predicate function calls.
---

diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb
index eaf9a257ba0..0a54b3eda50 100644
--- a/gcc/ada/sem_warn.adb
+++ b/gcc/ada/sem_warn.adb
@@ -1982,6 +1982,16 @@ package body Sem_Warn is
                            then
                               return True;
 
+                           --  Verify we are not within a generated predicate
+                           --  function call.
+
+                           elsif Nkind (Nod) = N_Function_Call
+                             and then Is_Entity_Name (Name (Nod))
+                             and then Is_Predicate_Function
+                                        (Entity (Name (Nod)))
+                           then
+                              return True;
+
                            elsif Present (Parent (Nod)) then
                               P := Parent (Nod);