From: Mike Stepanek (mstepane) <mstepane@cisco.com>
Date: Wed, 24 Oct 2018 17:58:21 +0000 (-0400)
Subject: Merge pull request #1400 in SNORT/snort3 from fix_static_analyzer_issue to master
X-Git-Tag: 3.0.0-249~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b86c7da31fae5935b7ec5bf1f299286ba3cc71f;p=thirdparty%2Fsnort3.git

Merge pull request #1400 in SNORT/snort3 from fix_static_analyzer_issue to master

Squashed commit of the following:

commit 604156554b3de3c7c92bf98e0fe69212fdb3b566
Author: Devendra Dahiphale <ddahipha@cisco.com>
Date:   Wed Oct 24 10:31:36 2018 -0400

    snort2lua: Avoid returning reference of local variable
---

diff --git a/tools/snort2lua/data/dt_rule_api.cc b/tools/snort2lua/data/dt_rule_api.cc
index 8a06afba5..e8bf89967 100644
--- a/tools/snort2lua/data/dt_rule_api.cc
+++ b/tools/snort2lua/data/dt_rule_api.cc
@@ -162,9 +162,8 @@ void RuleApi::add_hdr_data(const std::string& data)
 
 std::string& RuleApi::get_rule_old_action()
 {
-    std::string res = "";
     if (!curr_rule)
-        return res;
+        begin_rule();
 
     return (curr_rule->get_rule_old_action());
 }