From: lpsolit%gmail.com <>
Date: Tue, 21 Jun 2005 05:20:49 +0000 (+0000)
Subject: Backing out bug 180792. A table is locked as READ while my patch tries to write in... 
X-Git-Tag: bugzilla-2.20rc1~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b8d70a6a120da140ed41b37c5d98a902e16cae4;p=thirdparty%2Fbugzilla.git

Backing out bug 180792. A table is locked as READ while my patch tries to write in it :(
---

diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm
index 765ad9afad..10cbcd0d07 100644
--- a/Bugzilla/Flag.pm
+++ b/Bugzilla/Flag.pm
@@ -447,9 +447,6 @@ sub update_activity {
                   (bug_id, attach_id, who, bug_when, fieldid, removed, added)
                   VALUES ($bug_id, $attach_id, $::userid, $timestamp,
                   $field_id, $sql_removed, $sql_added)");
-
-        $dbh->do("UPDATE bugs SET delta_ts = $timestamp WHERE bug_id = ?",
-                 undef, $bug_id);
     }
 }
 
diff --git a/attachment.cgi b/attachment.cgi
index 0ed608c521..8b9bdaafd5 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -1251,7 +1251,7 @@ sub update
 
   # If the user submitted a comment while editing the attachment,
   # add the comment to the bug.
-  if ($cgi->param('comment'))
+  if (defined $cgi->param('comment'))
   {
     # Prepend a string to the comment to let users know that the comment came
     # from the "edit attachment" screen.