From: Victor Julien <victor@inliniac.net>
Date: Sun, 17 Dec 2017 19:08:12 +0000 (+0100)
Subject: detect/mpm: micro optimization in setup
X-Git-Tag: suricata-4.1.0-beta1~418
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b97fbbc137fa4e077019b7c690b6723129d6a40;p=thirdparty%2Fsuricata.git

detect/mpm: micro optimization in setup
---

diff --git a/src/detect-engine-mpm.c b/src/detect-engine-mpm.c
index 845341fe98..7bf4a74e99 100644
--- a/src/detect-engine-mpm.c
+++ b/src/detect-engine-mpm.c
@@ -933,6 +933,8 @@ static void MpmStoreSetup(const DetectEngineCtx *de_ctx, MpmStore *ms)
             s = de_ctx->sig_array[sig];
             if (s == NULL)
                 continue;
+            if ((s->flags & ms->direction) == 0)
+                continue;
             if (s->init_data->mpm_sm == NULL)
                 continue;
             int list = SigMatchListSMBelongsTo(s, s->init_data->mpm_sm);
@@ -940,8 +942,6 @@ static void MpmStoreSetup(const DetectEngineCtx *de_ctx, MpmStore *ms)
                 continue;
             if (list != ms->sm_list)
                 continue;
-            if ((s->flags & ms->direction) == 0)
-                continue;
 
             SCLogDebug("adding %u", s->id);