From: Ralph Boehme <slow@samba.org>
Date: Tue, 21 Jan 2020 10:56:18 +0000 (+0100)
Subject: libcli: simplify an if condition
X-Git-Tag: ldb-2.2.0~242
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b9ddce90c91ab3ef041dc779bce243a2d5ce001;p=thirdparty%2Fsamba.git

libcli: simplify an if condition

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/libcli/security/security_token.c b/libcli/security/security_token.c
index ef6ee0ff661..ad03f2d100d 100644
--- a/libcli/security/security_token.c
+++ b/libcli/security/security_token.c
@@ -70,7 +70,10 @@ void security_token_debug(int dbg_class, int dbg_lev, const struct security_toke
 
 bool security_token_is_sid(const struct security_token *token, const struct dom_sid *sid)
 {
-	if (token->sids && dom_sid_equal(&token->sids[PRIMARY_USER_SID_INDEX], sid)) {
+	if (token->sids == NULL) {
+		return false;
+	}
+	if (dom_sid_equal(&token->sids[PRIMARY_USER_SID_INDEX], sid)) {
 		return true;
 	}
 	return false;