From: Willy Tarreau <w@1wt.eu>
Date: Tue, 7 Apr 2009 11:27:40 +0000 (+0200)
Subject: [BUG] stats: total and lbtot are unsigned
X-Git-Tag: v1.3.18~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bba5a8f6c4e9ac4fe296cd6b513d28fe5a39031;p=thirdparty%2Fhaproxy.git

[BUG] stats: total and lbtot are unsigned

Some big users are seeing negative numbers in the CSV stats. This patch
needs to be backported to 1.3.15 and extended to the HTML part.
---

diff --git a/src/dumpstats.c b/src/dumpstats.c
index a4e80c2173..b132f71740 100644
--- a/src/dumpstats.c
+++ b/src/dumpstats.c
@@ -728,7 +728,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri)
 				     /* pxid, name, queue cur, queue max, */
 				     "%s,FRONTEND,,,"
 				     /* sessions : current, max, limit, total */
-				     "%d,%d,%d,%d,"
+				     "%d,%d,%d,%u,"
 				     /* bytes : in, out */
 				     "%lld,%lld,"
 				     /* denied: req, resp */
@@ -907,7 +907,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri)
 				     /* queue : current, max */
 				     "%d,%d,"
 				     /* sessions : current, max, limit, total */
-				     "%d,%d,%s,%d,"
+				     "%d,%d,%s,%u,"
 				     /* bytes : in, out */
 				     "%lld,%lld,"
 				     /* denied: req, resp */
@@ -966,7 +966,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri)
 				}
 
 				/* sessions: lbtot */
-				chunk_printf(&msg, sizeof(trash), ",%d,", sv->cum_lbconn);
+				chunk_printf(&msg, sizeof(trash), ",%u,", sv->cum_lbconn);
 
 				/* tracked */
 				if (sv->tracked)
@@ -1052,7 +1052,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri)
 				     /* queue : current, max */
 				     "%d,%d,"
 				     /* sessions : current, max, limit, total */
-				     "%d,%d,%d,%d,"
+				     "%d,%d,%d,%u,"
 				     /* bytes : in, out */
 				     "%lld,%lld,"
 				     /* denied: req, resp */
@@ -1070,7 +1070,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri)
 				     /* rest of backend: nothing, down transitions, last change, total downtime */
 				     ",%d,%d,%d,,"
 				     /* pid, iid, sid, throttle, lbtot, tracked, type */
-				     "%d,%d,0,,%d,,%d,"
+				     "%d,%d,0,,%u,,%d,"
 				     /* rate */
 				     "%u,"
 				     "\n",