From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 9 Jul 2025 06:41:24 +0000 (+0100)
Subject: Correct return value for comparison (CID #1655308)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bbf6b0e53fef9864ee2c54f8758df6b6d43d279;p=thirdparty%2Ffreeradius-server.git

Correct return value for comparison (CID #1655308)
---

diff --git a/src/listen/dhcpv4/proto_dhcpv4_udp.c b/src/listen/dhcpv4/proto_dhcpv4_udp.c
index 0429927543e..2a00c624f17 100644
--- a/src/listen/dhcpv4/proto_dhcpv4_udp.c
+++ b/src/listen/dhcpv4/proto_dhcpv4_udp.c
@@ -153,7 +153,7 @@ fr_dict_attr_autoload_t proto_dhcpv4_udp_dict_attr[] = {
 static int8_t dhcpv4_pcap_cmp(void const *a, void const *b)
 {
 	proto_dhcpv4_pcap_t const *one = a, *two = b;
-	return strcmp(one->interface, two->interface);
+	return CMP(strcmp(one->interface, two->interface), 0);
 }
 
 static proto_dhcpv4_pcap_t *dhcpv4_pcap_find(proto_dhcpv4_udp_thread_t *thread, char const *interface)