From: Frédéric Buclin <LpSolit@gmail.com>
Date: Mon, 27 Jan 2014 18:13:50 +0000 (+0100)
Subject: Bug 964113: Digest::SHA 5.82 and newer always croak on wide characters, preventing... 
X-Git-Tag: bugzilla-4.5.2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bd5bfb9b40bd81c546e7ae7a0a9ab281f308709;p=thirdparty%2Fbugzilla.git

Bug 964113: Digest::SHA 5.82 and newer always croak on wide characters, preventing saved searched from being displayed
r=dkl a=justdave
---

diff --git a/Bugzilla/Token.pm b/Bugzilla/Token.pm
index 9ebf9c6522..74f7805426 100644
--- a/Bugzilla/Token.pm
+++ b/Bugzilla/Token.pm
@@ -168,6 +168,10 @@ sub issue_hash_token {
     my @args = ($time, $user_id, @$data);
 
     my $token = join('*', @args);
+    # Wide characters cause Digest::SHA to die.
+    if (Bugzilla->params->{'utf8'}) {
+        utf8::encode($token) if utf8::is_utf8($token);
+    }
     $token = hmac_sha256_base64($token, Bugzilla->localconfig->{'site_wide_secret'});
     $token =~ s/\+/-/g;
     $token =~ s/\//_/g;
diff --git a/template/en/default/pages/release-notes.html.tmpl b/template/en/default/pages/release-notes.html.tmpl
index ef6090c415..f214bda0a5 100644
--- a/template/en/default/pages/release-notes.html.tmpl
+++ b/template/en/default/pages/release-notes.html.tmpl
@@ -61,6 +61,9 @@
   <li>An error about <kbd>longdescs.comment_id</kbd> was thrown by MySQL 5.0
     and 5.1 when upgrading to Bugzilla 4.4 or 4.4.1.
     (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=870369">[% terms.Bug %] 870369</a>)</li>
+  <li>Saved searches containing Unicode characters in their name could not
+    be run if Digest::SHA 5.82 or newer is installed.
+    (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=964113">[% terms.Bug %] 964113</a>)</li>
   <li>A regression in Bugzilla 4.4.1 caused <kbd>email_in.pl</kbd> to fail
     with an "invalid token" error message.
     (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=928331">[% terms.Bug %] 928331</a> and