From: Martin Willi <martin@revosec.ch>
Date: Mon, 1 Jul 2013 13:48:22 +0000 (+0200)
Subject: kernel-pfroute: use watcher to receive kernel events
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0be3e1e39331ef8bed3c16bee35c44365334b0eb;p=thirdparty%2Fstrongswan.git

kernel-pfroute: use watcher to receive kernel events
---

diff --git a/src/libhydra/plugins/kernel_pfroute/kernel_pfroute_net.c b/src/libhydra/plugins/kernel_pfroute/kernel_pfroute_net.c
index c05ca56ecc..ca2595d951 100644
--- a/src/libhydra/plugins/kernel_pfroute/kernel_pfroute_net.c
+++ b/src/libhydra/plugins/kernel_pfroute/kernel_pfroute_net.c
@@ -590,7 +590,8 @@ static void process_route(private_kernel_pfroute_net_t *this,
 /**
  * Receives PF_ROUTE messages from kernel
  */
-static job_requeue_t receive_events(private_kernel_pfroute_net_t *this)
+static bool receive_events(private_kernel_pfroute_net_t *this, int fd,
+						   watcher_event_t event)
 {
 	struct {
 		union {
@@ -601,36 +602,32 @@ static job_requeue_t receive_events(private_kernel_pfroute_net_t *this)
 		char buf[sizeof(struct sockaddr_storage) * RTAX_MAX];
 	} msg;
 	int len, hdrlen;
-	bool oldstate;
-
-	oldstate = thread_cancelability(TRUE);
-	len = recv(this->socket, &msg, sizeof(msg), 0);
-	thread_cancelability(oldstate);
 
+	len = recv(this->socket, &msg, sizeof(msg), MSG_DONTWAIT);
 	if (len < 0)
 	{
 		switch (errno)
 		{
 			case EINTR:
 			case EAGAIN:
-				return JOB_REQUEUE_DIRECT;
+				return TRUE;
 			default:
 				DBG1(DBG_KNL, "unable to receive from PF_ROUTE event socket");
 				sleep(1);
-				return JOB_REQUEUE_FAIR;
+				return TRUE;
 		}
 	}
 
 	if (len < offsetof(struct rt_msghdr, rtm_flags) || len < msg.rtm.rtm_msglen)
 	{
 		DBG1(DBG_KNL, "received invalid PF_ROUTE message");
-		return JOB_REQUEUE_DIRECT;
+		return TRUE;
 	}
 	if (msg.rtm.rtm_version != RTM_VERSION)
 	{
 		DBG1(DBG_KNL, "received PF_ROUTE message with unsupported version: %d",
 			 msg.rtm.rtm_version);
-		return JOB_REQUEUE_DIRECT;
+		return TRUE;
 	}
 	switch (msg.rtm.rtm_type)
 	{
@@ -647,12 +644,12 @@ static job_requeue_t receive_events(private_kernel_pfroute_net_t *this)
 			hdrlen = sizeof(msg.rtm);
 			break;
 		default:
-			return JOB_REQUEUE_DIRECT;
+			return TRUE;
 	}
 	if (msg.rtm.rtm_msglen < hdrlen)
 	{
 		DBG1(DBG_KNL, "ignoring short PF_ROUTE message");
-		return JOB_REQUEUE_DIRECT;
+		return TRUE;
 	}
 	switch (msg.rtm.rtm_type)
 	{
@@ -682,7 +679,7 @@ static job_requeue_t receive_events(private_kernel_pfroute_net_t *this)
 	this->condvar->broadcast(this->condvar);
 	this->mutex->unlock(this->mutex);
 
-	return JOB_REQUEUE_DIRECT;
+	return TRUE;
 }
 
 
@@ -1318,6 +1315,7 @@ METHOD(kernel_net_t, destroy, void,
 
 	if (this->socket != -1)
 	{
+		lib->watcher->remove(lib->watcher, this->socket);
 		close(this->socket);
 	}
 	enumerator = this->addrs->create_enumerator(this->addrs);
@@ -1389,10 +1387,8 @@ kernel_pfroute_net_t *kernel_pfroute_net_create()
 	}
 	else
 	{
-		lib->processor->queue_job(lib->processor,
-			(job_t*)callback_job_create_with_prio(
-					(callback_job_cb_t)receive_events, this, NULL,
-					(callback_job_cancel_t)return_false, JOB_PRIO_CRITICAL));
+		lib->watcher->add(lib->watcher, this->socket, WATCHER_READ,
+						  (watcher_cb_t)receive_events, this);
 	}
 	if (init_address_list(this) != SUCCESS)
 	{