From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 18 Nov 2013 13:18:04 +0000 (+0100)
Subject: expr: log: release prefix
X-Git-Tag: libnftnl-1.0.0~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bec6bc5e;p=thirdparty%2Flibnftnl.git

expr: log: release prefix

Ana Rey reported a leak in the log expression. Fix it by using
the new .free interface added in (3cf788a expr: fix leak in target
and match expressions).

Reported-by: Ana Rey Botello <anarey@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/expr/log.c b/src/expr/log.c
index 1f88246c..2d3e0cf7 100644
--- a/src/expr/log.c
+++ b/src/expr/log.c
@@ -268,10 +268,18 @@ nft_rule_expr_log_snprintf(char *buf, size_t len, uint32_t type,
 	return -1;
 }
 
+static void nft_rule_expr_log_free(struct nft_rule_expr *e)
+{
+	struct nft_expr_log *log = nft_expr_data(e);
+
+	xfree(log->prefix);
+}
+
 struct expr_ops expr_ops_log = {
 	.name		= "log",
 	.alloc_len	= sizeof(struct nft_expr_log),
 	.max_attr	= NFTA_LOG_MAX,
+	.free		= nft_rule_expr_log_free,
 	.set		= nft_rule_expr_log_set,
 	.get		= nft_rule_expr_log_get,
 	.parse		= nft_rule_expr_log_parse,