From: Philippe Antoine <pantoine@oisf.net>
Date: Thu, 27 Mar 2025 19:40:42 +0000 (+0100)
Subject: ci: make a build with ja disabled
X-Git-Tag: suricata-8.0.0-beta1~75
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bf0f90e97152b84613ed783abeb166521e3b2d5;p=thirdparty%2Fsuricata.git

ci: make a build with ja disabled

Ticket: 7461

In order to run all SV tests in CI, including the ones that
require the abse,ce of the JA3 or JA4 feature
---

diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml
index add1c0a25e..364e38cf09 100644
--- a/.github/workflows/builds.yml
+++ b/.github/workflows/builds.yml
@@ -845,8 +845,10 @@ jobs:
   # This job builds and tests Suricata as a non-root user as some
   # issues only show up when not running as root, and by default all
   # jobs in GitHub actions are run as root inside the container.
+  # Also ja3 and ja4 are disabled to run SV tests that require
+  # the absence of these features
   fedora-non-root:
-    name: Fedora (non-root, debug, clang, asan, wshadow, rust-strict)
+    name: Fedora (non-root, debug, clang, asan, wshadow, rust-strict, no-ja)
     runs-on: ubuntu-latest
     container: fedora:41
     needs: [prepare-deps, prepare-cbindgen]
@@ -906,7 +908,10 @@ jobs:
       - run: sudo -u suricata -s ./autogen.sh
         working-directory: /home/suricata/suricata
 
-      - run: sudo -u suricata -s env PATH="/home/suricata/.cargo/bin:$PATH" ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue
+      - run: >-
+          sudo -u suricata -s env PATH="/home/suricata/.cargo/bin:$PATH" ./configure --enable-warnings
+          --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis
+          --enable-nfqueue --disable-ja3 --disable-ja4
         working-directory: /home/suricata/suricata
         env:
           ac_cv_func_realloc_0_nonnull: "yes"
@@ -921,6 +926,12 @@ jobs:
       - run: sudo -u suricata -s make check
         working-directory: /home/suricata/suricata
 
+      - run: src/suricata --build-info | grep -E "JA3 support:\s+no" &> /dev/null
+        working-directory: /home/suricata/suricata
+
+      - run: src/suricata --build-info | grep -E "JA4 support:\s+no" &> /dev/null
+        working-directory: /home/suricata/suricata
+
       - run: sudo -u suricata -s python3 ./suricata-verify/run.py -q --debug-failed
         working-directory: /home/suricata/suricata