From: Greg Hudson <ghudson@mit.edu>
Date: Mon, 9 Apr 2018 15:00:05 +0000 (-0400)
Subject: Fix small leak in wshelper DLL
X-Git-Tag: krb5-1.17-beta1~143
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c013d6bc018d5be9f694ce80a27de740628133d;p=thirdparty%2Fkrb5.git

Fix small leak in wshelper DLL

Remove a double initialization of dwHesPwUidIndex in wshelper which
caused the first initialization to leak a thread-local storage handle.
Reported by Sergey Ilinykh.

ticket: 8663
---

diff --git a/src/util/wshelper/dllmain.c b/src/util/wshelper/dllmain.c
index 5ae0016e69..d3706d2143 100644
--- a/src/util/wshelper/dllmain.c
+++ b/src/util/wshelper/dllmain.c
@@ -43,8 +43,6 @@ DllMain(
             return FALSE;
 	if ((dwHesPwUidIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)
             return FALSE;
-	if ((dwHesPwUidIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)
-            return FALSE;
 	if ((dwGhnIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)
             return FALSE;
 	if ((dwGhaIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)