From: Mike Yuan <me@yhndnzj.com>
Date: Thu, 26 Feb 2026 10:07:39 +0000 (+0100)
Subject: sd-json: fix off-by-one issue when updating parent for array elements
X-Git-Tag: v257.11~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c0505046bf0f6768e1be67305f8605a3ffbc5b1;p=thirdparty%2Fsystemd.git

sd-json: fix off-by-one issue when updating parent for array elements

Follow-up for 8525bb369a09f488ec77f94e1557ecc2343eb4ab

(cherry picked from commit 4e6e3b8707c84018051ae1885af20e06b2a5209e)
(cherry picked from commit 372158ab0037733d8fd549fef728446765f3bed5)
(cherry picked from commit 96751656c216fee967be03b03a0671c84191e454)
---

diff --git a/src/libsystemd/sd-json/sd-json.c b/src/libsystemd/sd-json/sd-json.c
index ce368764b5e..91571631ac6 100644
--- a/src/libsystemd/sd-json/sd-json.c
+++ b/src/libsystemd/sd-json/sd-json.c
@@ -2243,7 +2243,7 @@ _public_ int sd_json_variant_append_array(sd_json_variant **v, sd_json_variant *
 
                         if (old != *v)
                                 /* Readjust the parent pointers to the new address */
-                                for (size_t i = 1; i < size; i++)
+                                for (size_t i = 0; i < size; i++)
                                         (*v)[1 + i].parent = *v;
 
                         return json_variant_array_put_element(*v, element);