From: Willy Tarreau <w@1wt.eu>
Date: Thu, 21 Jan 2021 08:13:35 +0000 (+0100)
Subject: MINOR: mux-h1/show_fd: report as suspicious an entry with too many calls
X-Git-Tag: v2.4-dev6~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c0c0a287834283eaaf5f25437a39a8f059e9878;p=thirdparty%2Fhaproxy.git

MINOR: mux-h1/show_fd: report as suspicious an entry with too many calls

An FD entry that maps to an H1 connection whose stream was woken
up more than 1M times is now flagged as suspicious.
---

diff --git a/src/mux_h1.c b/src/mux_h1.c
index ae50a5ef93..345161425e 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -3145,6 +3145,7 @@ static int h1_show_fd(struct buffer *msg, struct connection *conn)
 {
 	struct h1c *h1c = conn->ctx;
 	struct h1s *h1s = h1c->h1s;
+	int ret = 0;
 
 	chunk_appendf(msg, " h1c.flg=0x%x .sub=%d .ibuf=%u@%p+%u/%u .obuf=%u@%p+%u/%u",
 		      h1c->flags,  h1c->wait_event.events,
@@ -3176,12 +3177,14 @@ static int h1_show_fd(struct buffer *msg, struct connection *conn)
 				chunk_appendf(&trash, " tl.calls=%d tl.ctx=%p tl.fct=",
 					      h1s->subs->tasklet->calls,
 					      h1s->subs->tasklet->context);
+				if (h1s->subs->tasklet->calls >= 1000000)
+					ret = 1;
 				resolve_sym_name(&trash, NULL, h1s->subs->tasklet->process);
 				chunk_appendf(&trash, ")");
 			}
 		}
 	}
-	return 0;
+	return ret;
 }