From: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: Fri, 13 Nov 2020 20:05:30 +0000 (+0000)
Subject: Really update types on PostgresQuery.dump
X-Git-Tag: 3.0.dev0~366
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c22edd59ff17bbb244ccb9b6063b8a69fe590e5;p=thirdparty%2Fpsycopg.git

Really update types on PostgresQuery.dump

Let's do what it says on the tin, before micro-optimising.
---

diff --git a/psycopg3/psycopg3/utils/queries.py b/psycopg3/psycopg3/utils/queries.py
index a20273dbc..2d8bf6f60 100644
--- a/psycopg3/psycopg3/utils/queries.py
+++ b/psycopg3/psycopg3/utils/queries.py
@@ -75,26 +75,18 @@ class PostgresQuery:
             params = _validate_and_reorder_params(
                 self._parts, vars, self._order
             )
-            self.params = []
             assert self.formats is not None
-
-            if self.types is None:
-                self.types = []
-                for i, param in enumerate(params):
-                    if param is not None:
-                        dumper = self._tx.get_dumper(param, self.formats[i])
-                        self.params.append(dumper.dump(param))
-                        self.types.append(dumper.oid)
-                    else:
-                        self.params.append(None)
-                        self.types.append(UNKNOWN_OID)
-            else:
-                for i, param in enumerate(params):
-                    if param is not None:
-                        dumper = self._tx.get_dumper(param, self.formats[i])
-                        self.params.append(dumper.dump(param))
-                    else:
-                        self.params.append(None)
+            ps = self.params = []
+            ts = self.types = []
+            for i in range(len(params)):
+                param = params[i]
+                if param is not None:
+                    dumper = self._tx.get_dumper(param, self.formats[i])
+                    ps.append(dumper.dump(param))
+                    ts.append(dumper.oid)
+                else:
+                    ps.append(None)
+                    ts.append(UNKNOWN_OID)
         else:
             self.params = self.types = None