From: mkanat%bugzilla.org <>
Date: Thu, 31 Dec 2009 13:01:47 +0000 (+0000)
Subject: Bug 531841: Change all hour-related database fields to decimal(7,3) so that they... 
X-Git-Tag: bugzilla-3.5.3~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c266590b454f88f55fb4b39a5bce5532ca5baa0;p=thirdparty%2Fbugzilla.git

Bug 531841: Change all hour-related database fields to decimal(7,3) so that they can store numbers greater than 999.99 in modern versions of MySQL.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat
---

diff --git a/Bugzilla/DB/Schema.pm b/Bugzilla/DB/Schema.pm
index dbea63f79f..8bee5dfe13 100644
--- a/Bugzilla/DB/Schema.pm
+++ b/Bugzilla/DB/Schema.pm
@@ -285,9 +285,9 @@ use constant ABSTRACT_SCHEMA => {
                                     NOTNULL => 1, DEFAULT => 'TRUE'},
             cclist_accessible   => {TYPE => 'BOOLEAN',
                                     NOTNULL => 1, DEFAULT => 'TRUE'},
-            estimated_time      => {TYPE => 'decimal(5,2)',
+            estimated_time      => {TYPE => 'decimal(7,2)',
                                     NOTNULL => 1, DEFAULT => '0'},
-            remaining_time      => {TYPE => 'decimal(5,2)',
+            remaining_time      => {TYPE => 'decimal(7,2)',
                                     NOTNULL => 1, DEFAULT => '0'},
             deadline            => {TYPE => 'DATETIME'},
             alias               => {TYPE => 'varchar(20)'},
@@ -395,7 +395,7 @@ use constant ABSTRACT_SCHEMA => {
                                 REFERENCES => {TABLE => 'profiles',
                                                COLUMN => 'userid'}},
             bug_when        => {TYPE => 'DATETIME', NOTNULL => 1},
-            work_time       => {TYPE => 'decimal(5,2)', NOTNULL => 1,
+            work_time       => {TYPE => 'decimal(7,2)', NOTNULL => 1,
                                 DEFAULT => '0'},
             thetext         => {TYPE => 'LONGTEXT', NOTNULL => 1},
             isprivate       => {TYPE => 'BOOLEAN', NOTNULL => 1,
diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm
index 7a9fa72d87..f6d6edcb1d 100644
--- a/Bugzilla/Install/DB.pm
+++ b/Bugzilla/Install/DB.pm
@@ -593,8 +593,8 @@ sub update_table_definitions {
     $dbh->bz_drop_column('products', 'milestoneurl');
 
     _add_allows_unconfirmed_to_product_table();
-
     _convert_flagtypes_fks_to_set_null();
+    _fix_decimal_types();
 
     ################################################################
     # New --TABLE-- changes should go *** A B O V E *** this point #
@@ -3354,6 +3354,14 @@ sub _convert_flagtypes_fks_to_set_null {
     }
 }
 
+sub _fix_decimal_types {
+    my $dbh = Bugzilla->dbh;
+    my $type = {TYPE => 'decimal(7,2)', NOTNULL => 1, DEFAULT => '0'};
+    $dbh->bz_alter_column('bugs', 'estimated_time', $type);
+    $dbh->bz_alter_column('bugs', 'remaining_time', $type);
+    $dbh->bz_alter_column('longdescs', 'work_time', $type);
+}
+
 1;
 
 __END__