From: NeilBrown <neilb@suse.de>
Date: Tue, 15 Mar 2011 03:51:12 +0000 (+1100)
Subject: managemon: Don't do spare assignment while any updates are pending.
X-Git-Tag: mdadm-3.1.5~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c4f6e378b4fd9518e1037caab4babacf41ea6c8;p=thirdparty%2Fmdadm.git

managemon: Don't do spare assignment while any updates are pending.

Spare assignment requires full knowledge of array state.  A pending
update might modify that state (such as a pending spare assignment)
so don't try while there are updates pending.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/managemon.c b/managemon.c
index 3cf2389a..26ff1877 100644
--- a/managemon.c
+++ b/managemon.c
@@ -398,7 +398,12 @@ static void manage_member(struct mdstat_ent *mdstat,
 	a->info.array.raid_disks = mdstat->raid_disks;
 	// MORE
 
-	if (a->check_degraded) {
+	/* We don't check the array while any update is pending, as it
+	 * might container a change (such as a spare assignment) which 
+	 * could affect our decisions.
+	 */
+	if (a->check_degraded &&
+	    update_queue == NULL && update_queue_pending == NULL) {
 		struct metadata_update *updates = NULL;
 		struct mdinfo *newdev = NULL;
 		struct active_array *newa;