From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Sat, 17 Feb 2018 21:16:38 +0000 (+0200)
Subject: LAYOUT=index: Don't mkdir index root directory at init
X-Git-Tag: 2.3.9~2202
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c53ce6cb7afde3ddee2b3f8eb297ab2c7b03482;p=thirdparty%2Fdovecot%2Fcore.git

LAYOUT=index: Don't mkdir index root directory at init

It's not really needed, since anything that needs it will automatically
mkdir it later as well. This also breaks using LAYOUT=index with mbox,
because the mbox code hasn't yet had a chance to override the index root
path so it was mkdired without the .imap/ suffix.
---

diff --git a/src/lib-storage/list/mailbox-list-index-backend.c b/src/lib-storage/list/mailbox-list-index-backend.c
index e13cd7d955..9608cacc54 100644
--- a/src/lib-storage/list/mailbox-list-index-backend.c
+++ b/src/lib-storage/list/mailbox-list-index-backend.c
@@ -45,18 +45,10 @@ static struct mailbox_list *index_list_alloc(void)
 
 static int index_list_init(struct mailbox_list *_list, const char **error_r)
 {
-	const char *dir;
-
 	if (!_list->mail_set->mailbox_list_index) {
 		*error_r = "LAYOUT=index requires mailbox_list_index=yes";
 		return -1;
 	}
-	if (mailbox_list_get_root_path(_list, MAILBOX_LIST_PATH_TYPE_INDEX, &dir) &&
-	    mailbox_list_mkdir_root(_list, dir, MAILBOX_LIST_PATH_TYPE_INDEX) < 0) {
-		*error_r = t_strdup_printf("Failed to create the index root directory: %s",
-					   mailbox_list_get_last_internal_error(_list, NULL));
-		return -1;
-	}
 	return 0;
 }