From: Herwin Weststrate <herwin@snt.utwente.nl>
Date: Sun, 27 Nov 2016 14:17:24 +0000 (+0100)
Subject: Use workaround for error logging in connection.c
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c695923e6bdcc9501789849df7bace7faadc663;p=thirdparty%2Ffreeradius-server.git

Use workaround for error logging in connection.c

We have defined a LOG_PREFIX_ARGS that will cause a null pointer
dereference in this specific scenario.
---

diff --git a/src/main/connection.c b/src/main/connection.c
index 6a785a4fc1e..2cb69cde19c 100644
--- a/src/main/connection.c
+++ b/src/main/connection.c
@@ -969,7 +969,8 @@ fr_connection_pool_t *fr_connection_pool_init(TALLOC_CTX *ctx,
 	 */
 	pool = talloc_zero(NULL, fr_connection_pool_t);
 	if (!pool) {
-		ERROR("%s: Out of memory", __FUNCTION__);
+		/* Simply using ERROR here results in a null pointer dereference */
+		_RADLOG(L_ERR, "%s: Out of memory", __FUNCTION__);
 		return NULL;
 	}