From: Oliver Kurth <okurth@vmware.com>
Date: Wed, 3 Jul 2019 21:28:56 +0000 (-0700)
Subject: Fix a Coverity issue reported in vgauth/serviceImpl/verify.c
X-Git-Tag: stable-11.0.0~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c6ad5edceca60dc05eb9f3b1ee6ac42dc0455ef;p=thirdparty%2Fopen-vm-tools.git

Fix a Coverity issue reported in vgauth/serviceImpl/verify.c
---

diff --git a/open-vm-tools/vgauth/serviceImpl/verify.c b/open-vm-tools/vgauth/serviceImpl/verify.c
index f69edc0ab..bda1013ea 100644
--- a/open-vm-tools/vgauth/serviceImpl/verify.c
+++ b/open-vm-tools/vgauth/serviceImpl/verify.c
@@ -1,5 +1,5 @@
 /*********************************************************
- * Copyright (C) 2011-2018 VMware, Inc. All rights reserved.
+ * Copyright (C) 2011-2019 VMware, Inc. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU Lesser General Public License as published
@@ -43,15 +43,9 @@
 VGAuthError
 ServiceInitVerify(void)
 {
-   VGAuthError err;
 
    CertVerify_Init();
-   err = SAML_Init();
-   if (err != VGAUTH_E_OK) {
-      goto done;
-   }
-done:
-   return err;
+   return SAML_Init();
 }