From: Victor Julien <vjulien@oisf.net>
Date: Fri, 4 Feb 2022 09:29:03 +0000 (+0100)
Subject: app-layer: fix error counter logic
X-Git-Tag: suricata-7.0.0-beta1~934
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ccf5b914766335425d262de7f69b959c527329c;p=thirdparty%2Fsuricata.git

app-layer: fix error counter logic
---

diff --git a/src/app-layer.c b/src/app-layer.c
index 149936b1a1..327abe68a1 100644
--- a/src/app-layer.c
+++ b/src/app-layer.c
@@ -1060,16 +1060,14 @@ void AppLayerSetupCounters()
 void AppLayerRegisterThreadCounters(ThreadVars *tv)
 {
     uint8_t ipprotos[] = { IPPROTO_TCP, IPPROTO_UDP };
-    uint8_t ipproto;
-    AppProto alproto;
     AppProto alprotos[ALPROTO_MAX];
-
     AppLayerProtoDetectSupportedAppProtocols(alprotos);
 
-    for (ipproto = 0; ipproto < IPPROTOS_MAX; ipproto++) {
-        uint8_t ipproto_map = FlowGetProtoMapping(ipprotos[ipproto]);
+    for (uint8_t p = 0; p < IPPROTOS_MAX; p++) {
+        const uint8_t ipproto = ipprotos[p];
+        const uint8_t ipproto_map = FlowGetProtoMapping(ipproto);
 
-        for (alproto = 0; alproto < ALPROTO_MAX; alproto++) {
+        for (AppProto alproto = 0; alproto < ALPROTO_MAX; alproto++) {
             if (alprotos[alproto] == 1) {
                 applayer_counters[ipproto_map][alproto].counter_id =
                     StatsRegisterCounter(applayer_counter_names[ipproto_map][alproto].name, tv);