From: Volker Lendecke <vl@samba.org>
Date: Wed, 18 Aug 2021 04:25:00 +0000 (+0200)
Subject: librpc: Simplify GUID_string2() by using GUID_buf_string()
X-Git-Tag: ldb-2.5.0~884
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0cddd3f2d66b3fb3af73d42df6c4d42aff7863d7;p=thirdparty%2Fsamba.git

librpc: Simplify GUID_string2() by using GUID_buf_string()

Avoid unnecessary talloc

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/librpc/ndr/uuid.c b/librpc/ndr/uuid.c
index 99d1a1be082..f7753a85f1a 100644
--- a/librpc/ndr/uuid.c
+++ b/librpc/ndr/uuid.c
@@ -222,9 +222,9 @@ _PUBLIC_ char* GUID_buf_string(const struct GUID *guid,
 
 _PUBLIC_ char *GUID_string2(TALLOC_CTX *mem_ctx, const struct GUID *guid)
 {
-	char *ret, *s = GUID_string(mem_ctx, guid);
-	ret = talloc_asprintf(mem_ctx, "{%s}", s);
-	talloc_free(s);
+	struct GUID_txt_buf buf;
+	char *ret = talloc_asprintf(
+		mem_ctx, "{%s}", GUID_buf_string(guid, &buf));
 	return ret;
 }