From: Willy Tarreau <w@1wt.eu>
Date: Fri, 17 Sep 2021 09:56:25 +0000 (+0200)
Subject: BUILD: sockpair: do not set unused flag
X-Git-Tag: v2.5-dev8~180
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ce77ac204e0d8f998dd20e0dc2a2c840c1dfc61;p=thirdparty%2Fhaproxy.git

BUILD: sockpair: do not set unused flag

Ilya reports in GH #1392 that clang 13 complains about a flag being added
to the "flags" parameter without being used later. That's generic code
that was shared from TCP but we can indeed drop this flag since it's used
for TFO which we don't have in socketpairs.
---

diff --git a/src/proto_sockpair.c b/src/proto_sockpair.c
index 0cb9ab1e9b..0357552baa 100644
--- a/src/proto_sockpair.c
+++ b/src/proto_sockpair.c
@@ -331,10 +331,6 @@ static int sockpair_connect_server(struct connection *conn, int flags)
 		return SF_ERR_INTERNAL;
 	}
 
-	/* if a send_proxy is there, there are data */
-	if (conn->send_proxy_ofs)
-		flags |= CONNECT_HAS_DATA;
-
 	if (global.tune.server_sndbuf)
                 setsockopt(fd, SOL_SOCKET, SO_SNDBUF, &global.tune.server_sndbuf, sizeof(global.tune.server_sndbuf));