From: Milos Nikic Date: Sat, 7 Feb 2026 01:06:17 +0000 (-0800) Subject: ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0cf9c58bf654d0f27abe18005281dbf9890de401;p=thirdparty%2Fkernel%2Fstable.git ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks If ext2_get_blocks() is called with maxblocks == 0, it currently triggers a BUG_ON(), causing a kernel panic. While this condition implies a logic error in the caller, a filesystem should not crash the system due to invalid arguments. Replace the BUG_ON() with a WARN_ON_ONCE() to provide a stack trace for debugging, and return -EINVAL to handle the error gracefully. Signed-off-by: Milos Nikic Link: https://patch.msgid.link/20260207010617.216675-1-nikic.milos@gmail.com Signed-off-by: Jan Kara --- diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index dbfe9098a124..18bf1a91dbc2 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -638,7 +638,8 @@ static int ext2_get_blocks(struct inode *inode, int count = 0; ext2_fsblk_t first_block = 0; - BUG_ON(maxblocks == 0); + if (WARN_ON_ONCE(maxblocks == 0)) + return -EINVAL; depth = ext2_block_to_path(inode,iblock,offsets,&blocks_to_boundary);