From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 17 Apr 2023 08:10:15 +0000 (+0200)
Subject: networkRefreshDhcpDaemon: Get dnsmasq's PID once
X-Git-Tag: v9.3.0-rc1~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d0604a51a5674e432335d201418cbba80899b73;p=thirdparty%2Flibvirt.git

networkRefreshDhcpDaemon: Get dnsmasq's PID once

This is a relic of commit v3.7.0-rc1~132 when getter/setter APIs
for dnsmasq's PID were introduced. Previously, obj->dnsmasqPid
was accessed directly. But the aforementioned commit introduced
two calls to virNetworkObjGetDnsmasqPid() even though the result
of the first call is stored in a variable.

Remove the second call as it's unnecessary.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 7f2298a15e..9eb543a0a3 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -1599,7 +1599,6 @@ networkRefreshDhcpDaemon(virNetworkDriverState *driver,
     if (dnsmasqSave(dctx) < 0)
         return -1;
 
-    dnsmasqPid = virNetworkObjGetDnsmasqPid(obj);
     return kill(dnsmasqPid, SIGHUP);
 
 }