From: Peter Krempa Date: Thu, 25 May 2017 11:09:36 +0000 (+0200) Subject: qemu: Use correct variable in qemuDomainSetBlockIoTune X-Git-Tag: v3.4.0-rc1~19 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d3aff58e7ed190c97b40ee92f58cb0180cef6fe;p=thirdparty%2Flibvirt.git qemu: Use correct variable in qemuDomainSetBlockIoTune 'param' contains the correct element from 'params'. If the group name would not be the first parameter libvirtd would crash. Introduced in c53bd25b13. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1455510 --- diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index cd513ff9f8..67f54282a0 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17443,7 +17443,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, /* NB: Cannot use macro since this is a value.s not a value.ul */ if (STREQ(param->field, VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME)) { - if (VIR_STRDUP(info.group_name, params->value.s) < 0) + if (VIR_STRDUP(info.group_name, param->value.s) < 0) goto endjob; set_fields |= QEMU_BLOCK_IOTUNE_SET_GROUP_NAME; if (virTypedParamsAddString(&eventParams, &eventNparams,