From: Harlan Stenn <stenn@ntp.org>
Date: Mon, 26 Jun 2006 05:10:19 +0000 (-0400)
Subject: setsockopt() notes
X-Git-Tag: NTP_4_2_3P11~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d58e77aa2207fbc7d5a9f430b1488233d786a0c;p=thirdparty%2Fntp.git

setsockopt() notes

bk: 449f6c3blbBWg-iJvGytDx-nCHd8Lg
---

diff --git a/ntpd/ntp_io.c b/ntpd/ntp_io.c
index b9a35805a..8e9d1f6ae 100644
--- a/ntpd/ntp_io.c
+++ b/ntpd/ntp_io.c
@@ -1460,7 +1460,7 @@ static isc_boolean_t
 socket_broadcast_disable(struct interface *iface, struct sockaddr_storage *maddr)
 {
 #ifdef SO_BROADCAST
-	int off = 0;	/* XXX: Should this be a u_char (Bug 657)? */
+	int off = 0;	/* This seems to be OK as an int */
 
 	if (maddr->ss_family == AF_INET)
 	{
@@ -2119,7 +2119,8 @@ open_socket(
 {
 	int errval;
 	SOCKET fd;
-	int on = 1, off = 0;	/* XXX: Should these be u_char (bug 657)? */
+	int on = 1, off = 0;	/* int is OK for REUSEADR per */
+				/* http://www.kohala.com/start/mcast.api.txt */
 #if defined(IPTOS_LOWDELAY) && defined(IPPROTO_IP) && defined(IP_TOS)
 	int tos;
 #endif /* IPTOS_LOWDELAY && IPPROTO_IP && IP_TOS */