From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 17 Jul 2023 18:23:22 +0000 (+0200)
Subject: ngtcp2: assigning timeout, but value is overwritten before used
X-Git-Tag: curl-8_2_0~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d59aea93f9ba7dfbd5b153ddae95cc0b083394a;p=thirdparty%2Fcurl.git

ngtcp2: assigning timeout, but value is overwritten before used

Reported by Coverity

Closes #11453
---

diff --git a/lib/vquic/curl_ngtcp2.c b/lib/vquic/curl_ngtcp2.c
index 5db9df57ac..1d68fc0f1a 100644
--- a/lib/vquic/curl_ngtcp2.c
+++ b/lib/vquic/curl_ngtcp2.c
@@ -1000,7 +1000,6 @@ static CURLcode check_and_set_expiry(struct Curl_cfilter *cf,
   struct cf_ngtcp2_ctx *ctx = cf->ctx;
   struct pkt_io_ctx local_pktx;
   ngtcp2_tstamp expiry;
-  ngtcp2_duration timeout;
 
   if(!pktx) {
     pktx_init(&local_pktx, cf, data);
@@ -1021,7 +1020,6 @@ static CURLcode check_and_set_expiry(struct Curl_cfilter *cf,
         ngtcp2_ccerr_set_liberr(&ctx->last_error, rv, NULL, 0);
         return CURLE_SEND_ERROR;
       }
-      timeout = 0;
       result = cf_progress_ingress(cf, data, pktx);
       if(result)
         return result;
@@ -1033,7 +1031,7 @@ static CURLcode check_and_set_expiry(struct Curl_cfilter *cf,
     }
 
     if(expiry > pktx->ts) {
-      timeout = expiry - pktx->ts;
+      ngtcp2_duration timeout = expiry - pktx->ts;
       if(timeout % NGTCP2_MILLISECONDS) {
         timeout += NGTCP2_MILLISECONDS;
       }