From: Jouni Malinen <jouni@qca.qualcomm.com>
Date: Tue, 7 Feb 2017 18:50:33 +0000 (+0200)
Subject: FILS: Clean up HLP resize check
X-Git-Tag: hostap_2_7~1650
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d6dc6830c877092b6cea234fbc34a8773938603;p=thirdparty%2Fhostap.git

FILS: Clean up HLP resize check

The "!wpabuf_resize(...) == 0" condition does not make any sense. It
happens to work, but this is really supposed to simple check with
wpabuf_resize() returns non-zero and "wpabuf_resize(...)" is the
cleanest way of doing so.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
---

diff --git a/src/ap/fils_hlp.c b/src/ap/fils_hlp.c
index c66c1f15f..40d9be145 100644
--- a/src/ap/fils_hlp.c
+++ b/src/ap/fils_hlp.c
@@ -281,8 +281,8 @@ static void fils_dhcp_handler(int sd, void *eloop_ctx, void *sock_ctx)
 	} else {
 		wpabuf_put_data(resp, pos, end - pos);
 	}
-	if (!wpabuf_resize(&sta->fils_hlp_resp, wpabuf_len(resp) +
-			   2 * wpabuf_len(resp) / 255 + 100) == 0) {
+	if (wpabuf_resize(&sta->fils_hlp_resp, wpabuf_len(resp) +
+			  2 * wpabuf_len(resp) / 255 + 100)) {
 		wpabuf_free(resp);
 		return;
 	}