From: Victor Julien <victor@inliniac.net>
Date: Fri, 2 Mar 2012 08:23:29 +0000 (+0100)
Subject: Move PACKET_RECYCLE outside of flow lock in FlowForceReassemblyForQ as it confuses... 
X-Git-Tag: suricata-1.3beta1~139
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d6f33a15b4aea1924c4f9a1dcdf4f5791898a81;p=thirdparty%2Fsuricata.git

Move PACKET_RECYCLE outside of flow lock in FlowForceReassemblyForQ as it confuses static code checkers.
---

diff --git a/src/flow-timeout.c b/src/flow-timeout.c
index 00b0f31f06..09745baa12 100644
--- a/src/flow-timeout.c
+++ b/src/flow-timeout.c
@@ -454,10 +454,10 @@ static inline void FlowForceReassemblyForQ(FlowQueue *q)
 
     /* we need to loop through all the flows in the queue */
     while (f != NULL) {
-        SCMutexLock(&f->m);
-
         PACKET_RECYCLE(reassemble_p);
 
+        SCMutexLock(&f->m);
+
         /* Get the tcp session for the flow */
         ssn = (TcpSession *)f->protoctx;