From: Ilias Stamatis <stamatis.iliass@gmail.com>
Date: Wed, 19 Jun 2019 11:18:15 +0000 (+0200)
Subject: test_driver: validate @source in testDomainInterfaceAddresses
X-Git-Tag: v5.5.0-rc1~213
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d8079e9136fdc7964b5b2673e31bc4b49763ac2;p=thirdparty%2Flibvirt.git

test_driver: validate @source in testDomainInterfaceAddresses

Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index b95aaf41ca..2a0ffbc6c5 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3417,7 +3417,7 @@ static int testDomainBlockStats(virDomainPtr domain,
 static int
 testDomainInterfaceAddresses(virDomainPtr dom,
                              virDomainInterfacePtr **ifaces,
-                             unsigned int source ATTRIBUTE_UNUSED,
+                             unsigned int source,
                              unsigned int flags)
 {
     size_t i;
@@ -3430,6 +3430,13 @@ testDomainInterfaceAddresses(virDomainPtr dom,
 
     virCheckFlags(0, -1);
 
+    if (source >= VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST) {
+        virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
+                       _("Unknown IP address data source %d"),
+                       source);
+        return -1;
+    }
+
     if (!(vm = testDomObjFromDomain(dom)))
         goto cleanup;