From: Daniel P. Berrangé <berrange@redhat.com>
Date: Tue, 16 Feb 2021 12:18:55 +0000 (+0000)
Subject: qemu: use on|off instead of yes|no for -drive boolean properties
X-Git-Tag: v7.1.0-rc1~88
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d981fcd9754397b11b923ed10209239533f9e86;p=thirdparty%2Flibvirt.git

qemu: use on|off instead of yes|no for -drive boolean properties

QEMU has long accepted many different values for boolean properties, but
set accepted has been different depending on which QEMU parser you hit.

The on|off values were supported by all QEMU parsers. The yes|no, y|n,
true|false values were only partially supported:

  https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg01012.html

Thus we should standardize on on|off everywhere since that is most
widely supported in QEMU.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/util/virqemu.c b/src/util/virqemu.c
index 4136012c70..5b0dc25bc1 100644
--- a/src/util/virqemu.c
+++ b/src/util/virqemu.c
@@ -362,7 +362,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef)
 {
     g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
-    if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, false,
+    if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, true,
                                     virQEMUBuildCommandLineJSONArrayNumbered) < 0)
         return NULL;